Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lambda-promtail docs based on Owens review. #4548

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Improve lambda-promtail docs based on Owens review. #4548

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1073872
Improve lambda-promtail docs based on Owens review.
cstyan Oct 26, 2021
fcdef46
One last lambda-promtail docs improvement.
cstyan Oct 26, 2021
4f90c49
Fix bolding in lambda-promtail docs + include link to drop filter
cstyan Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/sources/clients/lambda-promtail/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ For both deployment types there are a few values that must be defined:

The Terraform deployment also takes in an array of log group names, and can take arrays for VPC subnets and security groups.

There's also a flag to keep the log group label when propagating the logs, which defaults to false.
There's also a flag to keep the log stream label when propagating the logs, which defaults to false. This can be helpful when the cardinality is too large, such as the case of a log stream per lambda invocation.

In an effort to make deployment of lambda-promtail as simple as possible, we've created a [public ECR repo](https://gallery.ecr.aws/grafana/lambda-promtail) to publish our builds of lambda-promtail. Users are still able to clone this repo, make their own modifications to the Go code, and upload their own image to their own ECR repo if they wish.

Expand All @@ -37,7 +37,7 @@ provider "aws" {

To keep the log group label add `-var "keep_stream=true"`.

Note that the automatic subscription filter creation to multiple log groups is done without the addition of any regex filtering on the logs contents.
Note that the creation of subscription filter in the provided Terraform file only accepts an array of log group names, it does nottake in strings for any regex filtering on the logs contents via the subscription filters. We suggest extending the Terraform file to do so, or having lambda-promtail write to Promtail and using pipeline stages.
cstyan marked this conversation as resolved.
Show resolved Hide resolved

CloudFormation:
```
Expand Down Expand Up @@ -140,7 +140,7 @@ scrape_configs:

## Multiple Promtail Deployment

Disclaimer: The following section is only relevant for older versions of Loki that cannot accept out of order logs.
** Disclaimer: The following section is only relevant for older versions of Loki that cannot accept out of order logs. **

However, these may only be active for a very short while. This creates a problem for combining these short-lived log streams in Loki because timestamps may not strictly increase across multiple log streams. The other obvious route is creating labels based on log streams, which is also undesirable because it leads to cardinality problems via many low-throughput log streams.

Expand Down