loki-mixin: use centralized configuration for dashboard matchers / selectors #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kevinschoonover
force-pushed
the
main
branch
from
c8c0865
to
b3d5623
Compare
kevinschoonover
force-pushed
the
main
branch
6 times, most recently
from
79904a5
to
8039701
Compare
owen-d
reviewed
Sep 28, 2021
|
Just curious, are the dashboards performing as you expect? |
|
When I was running them in isolation they were working (most likely because I was doing some overrides for my specific scenario). I just did a clean run of the dashboards and am seeing some missing recording rules, but this is likely because I'm using different selectors than stock (I'm using nomad and not k8s so namespace / datacenter instead of namespace / cluster). I don't have a very complex deployment so I don't know how well my testing will translate but let me take a deep look at it over the weekend to make sure they're performing exactly as I expect. Will follow back up with you when this is done. |
owen-d
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The dashboards have some boilerplate configuration copied at the top of each dashboard that means overwritting a selector, label, or otherwise must be done for each dashboard individually (at least thats what it looks like with my limited jsonnet experience). The PR adds 'job_names' and uses some of the unused functions in
dashboard-utils.libsonnetto centralize the configuration and make it feel like cortex-mixin / tempo-mixin.Dashboards updated:
- [ ] loki-logs.json- doesnt seem to be generated- [ ] loki-operational.json- doesnt seem to be generated