Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Inc() to correctly increment the dropStage.dropCount metric on valid dropped log line; update related docs #4246

Conversation

JordanRushing
Copy link
Contributor

What this PR does / why we need it:

When dropping a log line we are not currently incrementing the associated dropStage.dropCount metric.

Which issue(s) this PR fixes:

Fixes #4158

Special notes for your reviewer:
N/A

Checklist

  • [✅] Documentation added
  • [N/A] Tests updated

…metric on valid dropped log line; update related docs
@owen-d owen-d merged commit 0f0cb9f into grafana:main Aug 31, 2021
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promtail logentry_dropped_lines_total metric not incrementing
3 participants