Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/unordered writes ingester config #4192

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 18, 2021

This PR does a few things:

  1. Finishes removing the ingester.unordered-writes-enabled config. This has been entirely replaced by the per tenant limit configuration.
  2. Always replays WALs with unordered writes enabled. This primarily safeguards against dropping samples due to out_of_order errors when replaying a WAL after moving from unordered_writes: true -> unordered_writes: false. It does this by ensuring all the internals accept unordered writes during WAL replay and switches any differences at the end.
  3. Adds a new metric, loki_ingester_limiter_enabled, which reports when it's enabled/disabled. This should help debugging as it overrides some of the embedded overrides, particularly to disable them during WAL replay.

@owen-d owen-d requested a review from a team as a code owner August 18, 2021 22:13
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit ff2ced0 into grafana:main Aug 19, 2021
@owen-d
Copy link
Member Author

owen-d commented Aug 30, 2021

ref #1544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants