Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: example about using azure storage account as storage #4152

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

cbl315
Copy link
Contributor

@cbl315 cbl315 commented Aug 12, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #2907

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make suggested changes. Then, this documentation addition will LGTM.

docs/sources/storage/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes. The docs LGTM now. Please take care of signing the CLA, such that we can merge these changes in.

Signed-off-by: charles-woshicai <583605554@qq.com>
@cbl315
Copy link
Contributor Author

cbl315 commented Aug 17, 2021

Thank you for making the changes. The docs LGTM now. Please take care of signing the CLA, such that we can merge these changes in.

Done.

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@owen-d owen-d merged commit 345e101 into grafana:main Aug 19, 2021
@cbl315 cbl315 deleted the enhance-docs branch August 20, 2021 02:01
@hterik
Copy link
Contributor

hterik commented Sep 15, 2021

Hi
Being new to this, may i ask.

  1. Why is request_timeout set to 0, when default value is 30.
    It's easier to understand examples if they only contain the absolute minimum required configuration. If this deviation from the default is important, an explanation why would be good, and maybe in that case the default should be reconsidered.

  2. Why must the filesystem config be present?
    It appears counter-inuitive that one has to add filesystem config when wanting to use azure. Is this directory used for other temporary storage or is it a leftover from other config?

@thorker
Copy link
Contributor

thorker commented Apr 21, 2022

I stumpled at the same points.
Can someone please explain these configurations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Azure blob storage config examples to the docs
6 participants