Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: http_path_prefix as correct item of server_config #3868

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

sanadhis
Copy link
Contributor

@sanadhis sanadhis commented Jun 19, 2021

What this PR does / why we need it:
In https://grafana.com/docs/loki/latest/configuration/, the sub-server yaml key to configure base path for API routes should be http_path_prefix instead of http_prefix. This PR fixes the documentation.

Which issue(s) this PR fixes:
Not sure there is related issue yet.

Special notes for your reviewer:
My first PR in open-source world. Apologize if missing some details 😟

Checklist

  • Documentation added
  • Tests updated --Not needed

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sanadhis
Copy link
Contributor Author

Thanks for the approval @KMiller-Grafana
Unfortunately I cannot merge the PR.. 😢

@KMiller-Grafana KMiller-Grafana requested a review from a team June 21, 2021 17:53
@KMiller-Grafana
Copy link
Contributor

@sanadhis I've tagged the team to do a review/merge in. I also do not have merge permissions.

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just added a suggestion but otherwise it LGTM.

docs/sources/configuration/_index.md Outdated Show resolved Hide resolved
@sanadhis sanadhis force-pushed the feature/docs-http-path-prefix branch from c0e01f0 to 3875d4d Compare June 22, 2021 11:35
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! Thanks for this :)

@owen-d owen-d merged commit eab103f into grafana:main Jun 22, 2021
@sanadhis sanadhis deleted the feature/docs-http-path-prefix branch June 22, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants