Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes docker driver that would panic when closed. #3709

Merged
merged 1 commit into from
May 17, 2021

Conversation

cyriltovena
Copy link
Contributor

This is happening because it can still received log, but the client might be already closed.

Fixes #3705

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

This is happening because it can still received log, but the client might be already closed.

Fixes grafana#3705

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyriltovena cyriltovena merged commit 7a5fe3d into grafana:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker login plugin crashes
2 participants