Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtail: Added path information to deleted tailed file #3457

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

nmiculinic
Copy link
Contributor

What this PR does / why we need it:

This PR adds more information to

skipping update of position for a file which does not currently exist

that is, it adds which file we're talking about with this log message. I've encountered a large number of such messages, and am in process of debugging them.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nmiculinic
Copy link
Contributor Author

Signed CLA

@kavirajk
Copy link
Contributor

kavirajk commented Mar 9, 2021

@nmiculinic Thanks for improving the log message :)

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean merged commit b67a07e into grafana:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants