Fixes a tight loop in the Engine with LogQL parser. #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also added a test to prove the issue was happening and now is fixed. Fixes grafana#3275 Fixes grafana#3264 Fixes grafana#3020 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
dannykopping
approved these changes
Feb 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #3347 +/- ##
==========================================
+ Coverage 62.84% 62.86% +0.02%
==========================================
Files 205 205
Lines 17340 17341 +1
==========================================
+ Hits 10897 10902 +5
+ Misses 5462 5459 -3
+ Partials 981 980 -1
|
owen-d
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added a test to prove the issue was happening and now is fixed.
Fixes #3275
Fixes #3264
Fixes #3020
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com