Loki: Log a crude lag metric for how far behind a client is. #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry and the current time as a crude measure of how far behind a promtail instance is.
cyriltovena
reviewed
Jan 26, 2021
| for _, s := range req.Streams { | ||
| streamLabelsSize += int64(len(s.Labels)) | ||
| for _, e := range s.Entries { | ||
| totalEntries++ | ||
| entriesSize += int64(len(e.Line)) | ||
| if e.Timestamp.After(mostRecentEntry) { |
There was a problem hiding this comment.
should we just look at the last entry for each stream instead ?
There was a problem hiding this comment.
if len(s.Entries) > 0 {
last := s.Entries[len(s.Entries)-1].Timestamp
if last.Timestamp.After(mostRecentEntry) {
mostRecentEntry = last
}There was a problem hiding this comment.
if/when we support out of order the current implementation would handle that a little better but I agree this is a better optimization for our current constraints
owen-d
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the difference in time between the most recently received log entry and the current time as a crude measure of how far behind a client instance is.