Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the ability to read chunkFormatV3 while writing v2 #2984

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Nov 24, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2984 (d96c014) into master (56830bc) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
+ Coverage   61.77%   61.85%   +0.07%     
==========================================
  Files         182      182              
  Lines       14863    14863              
==========================================
+ Hits         9182     9193      +11     
+ Misses       4835     4822      -13     
- Partials      846      848       +2     
Impacted Files Coverage Δ
pkg/chunkenc/memchunk.go 73.67% <100.00%> (ø)
pkg/promtail/positions/positions.go 58.51% <0.00%> (+11.70%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit a8af1c0 into grafana:master Dec 1, 2020
slim-bean pushed a commit that referenced this pull request Dec 10, 2020
slim-bean pushed a commit that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants