Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update docs for redis #2728

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

vishesh92
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov-commenter
Copy link

Codecov Report

Merging #2728 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2728   +/-   ##
=======================================
  Coverage   61.37%   61.37%           
=======================================
  Files         173      173           
  Lines       13465    13465           
=======================================
  Hits         8264     8264           
  Misses       4447     4447           
  Partials      754      754           

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks !

@cyriltovena cyriltovena merged commit 2d59f89 into grafana:master Oct 7, 2020
@vishesh92 vishesh92 deleted the update-redis-cache-docs branch October 8, 2020 07:38
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…or disabling just index deduplication (grafana#2728)

* change flag DisableChunksDeduplication to DisableIndexDeduplication for disabling just index deduplication

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* tests and other changes suggested in PR review

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants