Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes r/w pools from block/chunk types #2711

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Oct 1, 2020

This PR lays some groundwork for the upcoming WAL work by disassociating reader/writer pools from memchunk & block types. These can be easily inferred and this should help reduce some complexity/make it easier to implement data-only types which can be more safely/effectively loaded to/from disk via []byte.

@codecov-commenter
Copy link

Codecov Report

Merging #2711 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2711      +/-   ##
==========================================
- Coverage   61.41%   61.35%   -0.06%     
==========================================
  Files         173      173              
  Lines       13444    13439       -5     
==========================================
- Hits         8257     8246      -11     
- Misses       4430     4440      +10     
+ Partials      757      753       -4     
Impacted Files Coverage Δ
pkg/chunkenc/memchunk.go 73.61% <100.00%> (-0.37%) ⬇️
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/logql/evaluator.go 92.38% <0.00%> (-0.43%) ⬇️
pkg/promtail/targets/file/filetarget.go 66.19% <0.00%> (+2.11%) ⬆️
pkg/promtail/targets/file/tailer.go 73.33% <0.00%> (+4.44%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder if block should be a pointer or not in encBlock, I'm not sure. We shall see.

@owen-d owen-d merged commit b878716 into grafana:master Oct 12, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
…r a user (grafana#2711)

* load delete requests frequently if there are more pending requests for a user

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* fix an issue with a minor nit

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants