pkg/chunkenc: fix test using string(int) conversion #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since go1.15, there's a new vet check for code such as string(x) where x has an integer type other than rune. This vet check is enabled by default on go test. TestSerialization failed because of that, this commit replaces `string()` conversions with `strconv.Itoa` calls Fixes grafana#2646
Codecov Report
@@ Coverage Diff @@
## master #2647 +/- ##
==========================================
+ Coverage 61.16% 61.23% +0.06%
==========================================
Files 172 172
Lines 13358 13358
==========================================
+ Hits 8171 8180 +9
+ Misses 4437 4429 -8
+ Partials 750 749 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since go1.15, there's a new vet check for code such as string(x) where x has an integer type other than rune. This vet check is enabled by default on go test.
TestSerializationfailed because of that, this commit replacesstring()conversions withstrconv.ItoacallsWhich issue(s) this PR fixes:
Fixes #2646
Special notes for your reviewer:
Checklist