Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes batch metrics help text & corrects bucketing #2552

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 25, 2020

Math was off, causing us to clip our upper bound bucket.

@codecov-commenter
Copy link

Codecov Report

Merging #2552 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2552      +/-   ##
==========================================
- Coverage   63.37%   63.35%   -0.03%     
==========================================
  Files         166      166              
  Lines       14582    14582              
==========================================
- Hits         9242     9238       -4     
- Misses       4599     4602       +3     
- Partials      741      742       +1     
Impacted Files Coverage Δ
pkg/storage/batch.go 85.98% <100.00%> (ø)
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 750ab36 into grafana:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants