Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm loki/promtail] Add systemd-journald example with extraMount, extraVolumeMount #1871

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

stefanandres
Copy link

This commit adds the variables extraMount and extraVolumeMount to the
promtail helm chart.

It also adds an example on how to use the helm chart with
systemd-journal support.

What this PR does / why we need it:

This PR makes it easier to use the promtail helm chart with systemd-journal support.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you so much for adding more docs, we do really appreciate it.

…ournal

This commit adds the variables extraMount and extraVolumeMount to the
promtail helm chart.

It also adds an example on how to use the helm chart with
systemd-journal support.
@cyriltovena cyriltovena merged commit 733b246 into grafana:master Mar 31, 2020
@stefanandres
Copy link
Author

Thanks for the quick review and merge! :)

@stefanandres stefanandres deleted the extramounts-journal branch April 1, 2020 06:45
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
…ournal (grafana#1871)

This commit adds the variables extraMount and extraVolumeMount to the
promtail helm chart.

It also adds an example on how to use the helm chart with
systemd-journal support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants