loki can not be started with loki-local-config.yaml #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 64.75% 64.80% +0.04%
==========================================
Files 122 122
Lines 9228 9228
==========================================
+ Hits 5976 5980 +4
+ Misses 2836 2833 -3
+ Partials 416 415 -1
|
cyriltovena
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
loki can not be started with loki-local-config.yaml, failed with
failed parsing config: loki-local-config.yaml: not a valid duration string: "0"
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
start loki with the updated loki-local-config.yaml
Checklist