Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki: Convert module names to string #1794

Merged
merged 1 commit into from
Mar 11, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 18 additions & 76 deletions pkg/loki/modules.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,22 +36,22 @@ import (

const maxChunkAgeForTableManager = 12 * time.Hour

type moduleName int
type moduleName string

// The various modules that make up Loki.
const (
Ring moduleName = iota
RuntimeConfig
Overrides
Server
Distributor
Ingester
Querier
QueryFrontend
Store
TableManager
MemberlistKV
All
Ring moduleName = "ring"
RuntimeConfig moduleName = "runtime-config"
Overrides moduleName = "overrides"
Server moduleName = "server"
Distributor moduleName = "distributor"
Ingester moduleName = "ingester"
Querier moduleName = "querier"
QueryFrontend moduleName = "query-frontend"
Store moduleName = "store"
TableManager moduleName = "table-manager"
MemberlistKV moduleName = "memberlist-kv"
All moduleName = "all"
)

func (m *moduleName) UnmarshalYAML(unmarshal func(interface{}) error) error {
Expand All @@ -64,74 +64,16 @@ func (m *moduleName) UnmarshalYAML(unmarshal func(interface{}) error) error {
}

func (m moduleName) String() string {
switch m {
case Ring:
return "ring"
case RuntimeConfig:
return "runtime-config"
case Overrides:
return "overrides"
case Server:
return "server"
case Distributor:
return "distributor"
case Store:
return "store"
case Ingester:
return "ingester"
case Querier:
return "querier"
case QueryFrontend:
return "query-frontend"
case TableManager:
return "table-manager"
case MemberlistKV:
return "memberlist-kv"
case All:
return "all"
default:
panic(fmt.Sprintf("unknown module name: %d", m))
}
return string(m)
}

func (m *moduleName) Set(s string) error {
switch strings.ToLower(s) {
case "ring":
*m = Ring
return nil
case "runtime-config":
*m = RuntimeConfig
return nil
case "overrides":
*m = Overrides
return nil
case "server":
*m = Server
return nil
case "distributor":
*m = Distributor
return nil
case "store":
*m = Store
return nil
case "ingester":
*m = Ingester
return nil
case "querier":
*m = Querier
return nil
case "query-frontend":
*m = QueryFrontend
return nil
case "table-manager":
*m = TableManager
return nil
case "all":
*m = All
return nil
default:
l := moduleName(strings.ToLower(s))
if _, ok := modules[l]; !ok {
return fmt.Errorf("unrecognised module name: %s", s)
}
*m = l
return nil
}

func (t *Loki) initServer() (err error) {
Expand Down