pkg/promtail: Initialize counters to 0 when creating client #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
force-pushed
the
promtail_counters
branch
2 times, most recently
from
a237c24
to
a2dbb6c
Compare
pracucci
approved these changes
Jan 10, 2020
This ensures metrics are not missing before they're incremented the first time, as recommended by the upstream Prometheus instrumentation guidelines: https://prometheus.io/docs/practices/instrumentation/#avoid-missing-metrics. Currently, in the case of dropped_entries_total and dropped_bytes_total, the metric is simply missing until the first occurrence of an entry being dropped.
chancez
force-pushed
the
promtail_counters
branch
from
a2dbb6c
to
cdf7083
Compare
|
@cyriltovena This PR LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This ensures metrics are not missing before they're incremented the first
time, as recommended by the upstream Prometheus instrumentation guidelines:
https://prometheus.io/docs/practices/instrumentation/#avoid-missing-metrics.
Currently, in the case of dropped_entries_total and dropped_bytes_total,
the metric is simply missing until the first occurrence of an entry
being dropped.
Checklist