Enable -race when running tests. Fixed couple of race errors. #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pstibrany
changed the title
pstibrany
referenced
this pull request
in grafana/tail
Nov 19, 2019
|
If races in promtail are fixed, then there is still race in some new ingester tests. @rfratto would you please take a look? |
2 tasks
TestChunkFlushingIdle needed sleep time lengthened to deal with extra time it takes to execute code with the race checker enabled.
|
@pstibrany I fixed the test errors in the ingester. |
|
Wonderful, thanks a lot @rfratto! |
|
working on the fix for the tail lib, and I have a fix for the other promtail test |
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
keep this open pls stalebot
…On Sat, Jan 11, 2020 at 5:21 PM stale[bot] ***@***.***> wrote:
This issue has been automatically marked as stale because it has not had
any activity in the past 30 days. It will be closed in 7 days if no further
activity occurs. Thank you for your contributions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1283?email_source=notifications&email_token=ACO2RKYID56PYJXV3S7ZSZLQ5JA6PA5CNFSM4JO7V6JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWMLQY#issuecomment-573359555>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACO2RK5CKHOSMC2L3R4UQKDQ5JA6PANCNFSM4JO7V6JA>
.
|
stale
bot
removed
the
stale
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed couple of reported errors when running tests with -race option.
There are few more remaining.