Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The official Linux release binary of promtail 2.8.0 is built without systemd journal support (on at least amd64) #9060

Closed
siebenmann opened this issue Apr 6, 2023 · 9 comments
Closed

The official Linux release binary of promtail 2.8.0 is built without systemd journal support (on at least amd64) #9060

siebenmann opened this issue Apr 6, 2023 · 9 comments
Assignees
@trevorwhitney @jeschkies
Labels
component/promtail type/bug Somehing is not working as expected type/build

Comments

@siebenmann
Copy link

Describe the bug
The official promtail binaries for Linux amd64 are built without support for reading from the systemd journal. Starting them with the journal configured as a log source gets you:

level=info ts=2023-04-06T15:19:32.082276461Z caller=promtail.go:133 msg="Reloading configuration file" md5sum=f77bc87e64d66cca88ef9c78b403eb79
level=warn ts=2023-04-06T15:19:32.082499874Z caller=journaltargetmanager.go:29 msg="WARNING!!! Journal target was configured but support for reading the systemd journal is not compiled into this build of promtail!"
level=info ts=2023-04-06T15:19:32.084100883Z caller=server.go:323 http=[::]:9080 grpc=[::]:9095 msg="server listening on addresses"
level=info ts=2023-04-06T15:19:32.084264747Z caller=main.go:174 msg="Starting Promtail" version="(version=2.8.0, branch=HEAD, revision=90888a0cc)"
level=warn ts=2023-04-06T15:19:32.084327616Z caller=promtail.go:265 msg="enable watchConfig"

I suspect that promtail binaries were not built with the new build tag to include the journal that's covered in the 2.8 upgrade notes.
@m1keil
Copy link
Contributor

m1keil commented Apr 8, 2023 •
edited
Loading

just hit the same issue. This problem seem to be recurring and previously impacted arm64 builds, but now amd64 as well. Had to roll back to 2.7.5

@m1keil m1keil mentioned this issue Apr 8, 2023
Closed
@dannykopping
Copy link
Contributor

Thank you for reporting this.

We will get it sorted out and update our build automation to prevent reoccurrences in the future.

@dannykopping dannykopping added component/promtail type/build type/bug Somehing is not working as expected labels Apr 10, 2023
@trevorwhitney
Copy link
Collaborator

could it be related to this: #7587?

@jeschkies
Copy link
Contributor

This is interesting. I've added journald support for ARM and ARM64 in 4504ed2. However, when you look at the diff you'll see that our release target dist would never enbale journald.

@jeschkies jeschkies self-assigned this Apr 11, 2023
@jeschkies jeschkies mentioned this issue Apr 11, 2023
Closed
5 tasks
@jeschkies
Copy link
Contributor

jeschkies commented Apr 11, 2023 •
edited
Loading

This fix is up for review. I was a little confused when this regression was introduced though. Trevor's linked change is half a year old. However, it turns out that we cut 2.7 around the same time as #7587 landed on main. That's why it went unnoticed for so long.

@JordanRushing JordanRushing mentioned this issue Apr 11, 2023
Merged
5 tasks
JordanRushing added a commit that referenced this issue Apr 11, 2023
@JordanRushing @trevorwhitney
Add journald support to Promtail amd64 binary builds (#9095)
7edda37 
**What this PR does / why we need it**:

Previously, in #8131, we enabled
journald support for Promtail arm/arm64 binary builds but not amd64.

**Which issue(s) this PR fixes**:

- #9060

**Special notes for your reviewer**:

N/A

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`

---------

Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
grafanabot pushed a commit that referenced this issue Apr 11, 2023
@JordanRushing @grafanabot
Add journald support to Promtail amd64 binary builds (#9095)
aa3730c 
**What this PR does / why we need it**:

Previously, in #8131, we enabled
journald support for Promtail arm/arm64 binary builds but not amd64.

**Which issue(s) this PR fixes**:

- #9060

**Special notes for your reviewer**:

N/A

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/upgrading/_index.md`

---------

Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
(cherry picked from commit 7edda37)
@trevorwhitney
Copy link
Collaborator

Fixed by #9095, working on a 2.8.1 now

@ajs124 ajs124 mentioned this issue Apr 13, 2023
Merged
12 tasks
@frittentheke
Copy link
Contributor

@trevorwhitney are you pushing out that 2.8.1 with just journald support (re)added or are you waiting for more bugfixes?

@trevorwhitney
Copy link
Collaborator

It will go out this week. There were a couple other fixes we wanted in there.

@trevorwhitney
Copy link
Collaborator

fixed in the latest release! https://github.com/grafana/loki/releases/tag/v2.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorwhitney trevorwhitney

@jeschkies jeschkies

Labels
component/promtail type/bug Somehing is not working as expected type/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable journald for Promtail AMD64 build. jeschkies/loki
6 participants
@dannykopping @trevorwhitney @siebenmann @m1keil @jeschkies @frittentheke