Version not included in promtail user-agent #4686
Comments
|
Yeah it seems that the code for the agent will be run before the version initialization here. https://github.com/grafana/loki/blob/main/pkg/util/build/build.go#L23 |
cyriltovena
added a commit
to cyriltovena/loki
that referenced
this issue
Nov 9, 2021
This was because promtail client was still user the old version.Version which is initialized at run-time via init. But if we use it also at init time there's no guarantee that the version will be set. So intead I'm using the original version variable stamped in the binary and not at runtime. Fixes grafana#4686 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
dannykopping
pushed a commit
that referenced
this issue
Nov 9, 2021
This was because promtail client was still user the old version.Version which is initialized at run-time via init. But if we use it also at init time there's no guarantee that the version will be set. So intead I'm using the original version variable stamped in the binary and not at runtime. Fixes #4686 Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The promtail user-agent doesn't include the version.
To Reproduce
Steps to reproduce the behavior:
docker.io/grafana/promtail:2.4.0) with a client config pointing to some serverExpected behavior
The user-agent should be
promtail/2.4.0Environment:
Screenshots, Promtail config, or terminal output
Nginx log:
Version:
root@eeb8923229d1:/# promtail --version promtail, version 2.4.0 (branch: HEAD, revision: 3987933cd) build user: root@fc19e7dd4bc0 build date: 2021-11-05T20:46:40Z go version: go1.17.2 platform: linux/amd64The text was updated successfully, but these errors were encountered: