Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promtail] imagepullsecret for private repos #2118

Closed
rayotte opened this issue May 22, 2020 · 0 comments · Fixed by #2141
Closed

[promtail] imagepullsecret for private repos #2118

rayotte opened this issue May 22, 2020 · 0 comments · Fixed by #2141

Comments

@rayotte
Copy link

rayotte commented May 22, 2020

Is your feature request related to a problem? Please describe.
The loki helm chart has an option in the values.yaml file to use image pull secrets in order to pull the image from a private repository:

 image:
  repository: grafana/loki
  tag: 1.5.0
  pullPolicy: IfNotPresent

  ## Optionally specify an array of imagePullSecrets.
  ## Secrets must be manually created in the namespace.
  ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
  ##
  # pullSecrets:
  #   - myRegistryKeySecretName

This config doesn't appear to be in the promtail chart values.yaml file. Is there a way to do this with the promtail chart as well or is it possible to have it added in to work the same way it does in the loki chart?

Additional context
Tried adding it to the promtail serviceaccount as well but that doesn't seem to support that either

cyriltovena added a commit to cyriltovena/loki that referenced this issue May 27, 2020
Fixes grafana#2118

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
owen-d pushed a commit that referenced this issue Jun 2, 2020
* Adds the ability to have a pull secrets for Promtail.

Fixes #2118

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* bump chart version

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
* Adds the ability to have a pull secrets for Promtail.

Fixes grafana#2118

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>

* bump chart version

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant