Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Add alert for discarded samples #13512

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

xperimental
Copy link
Collaborator

@xperimental xperimental commented Jul 12, 2024

What this PR does / why we need it:

This PR adds an alert to the set of alerts provided by the operator, that fires when there are samples discarded by Loki during ingestion. It should only alert on non-retryable errors.

Which issue(s) this PR fixes:

Fixes LOG-5731

Special notes for your reviewer:

The threshold for alerting is currently set to "zero". This means that the alert will fire if any samples are discarded. I don't think we can do an alerting based on percentage here (because I do not see a metric for "accepted samples") or if it makes any sense.

I'm looking into extending the unit-tests we have for alerts to also cover this alert.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here

@xperimental xperimental force-pushed the alert-discarded-samples branch 2 times, most recently from c8b3a0f to 4547f1d Compare July 25, 2024 17:16
@xperimental xperimental marked this pull request as ready for review July 26, 2024 15:36
@xperimental xperimental requested review from periklis and a team as code owners July 26, 2024 15:36
@periklis periklis merged commit 5f2a02f into grafana:main Jul 29, 2024
69 checks passed
@xperimental xperimental deleted the alert-discarded-samples branch July 29, 2024 15:33
xperimental added a commit to xperimental/loki that referenced this pull request Jul 29, 2024
benclive pushed a commit to cyriltovena/loki that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants