Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase drain max depth from 8 -> 30 #13063

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

benclive
Copy link
Contributor

What this PR does / why we need it:
Main change is to bump the max log depth in Drain config to 30. This lets it find patterns in a wider variety of logs, and performs significantly better in some cases (systemd logs in particular).

The trade off here is that it tends to generate more patterns which will result in more memory usage. Improvements to resource usage will follow in more PRs.

Also a few small iterative improvements:

  • Sort test output for stability
  • Add benchmark to get a baseline for allocations etc.
  • Add a test flag to generate test-friendly output to update the patterns in the test cases.

@benclive benclive requested a review from a team as a code owner May 29, 2024 09:21
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit d0a2859 into main May 29, 2024
60 checks passed
@cyriltovena cyriltovena deleted the increase-drain-max-depth branch May 29, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants