fix: respect query matcher in ingester when getting label values #10375
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasslessParticle
approved these changes
Aug 28, 2023
|
Tested locally with single binary and SSD mode (docker), and on a microservices dev env. Worked in all 3 places |
This was referenced Oct 26, 2023
Merged
Merged
periklis
pushed a commit
that referenced
this pull request
Nov 6, 2023
periklis
pushed a commit
that referenced
this pull request
Nov 6, 2023
This was referenced Mar 25, 2024
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug when passing a query parameter to the
/label/:label/values. Currently the ingester is not respecting this query string, and so is always returning all label values. This PR fixes that bug.