-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(docker-driver): Multiplex the client.batchSend
promtail `client` stop is not propaged properly to the its `batchSend` method in the `run` method. though `run` method multiplex on `c.quit` channel, the other branch can block in `batchSend` without even listening on the `c.quit` channel on the `run` method. This fixes the it by multiplex on `c.quit` inside the batchSend as well. Other suggestion: expose `client.run` to promtail client and they control it via context. But that requires API changes like accepting `ctx` in `client.Run` method.
- Loading branch information
Showing
2 changed files
with
60 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters