Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP input timeouts #318

Merged
merged 13 commits into from
Oct 23, 2018
Merged

TCP input timeouts #318

merged 13 commits into from
Oct 23, 2018

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Oct 22, 2018 •
edited
Loading

this PR consists of:

  • read timeouts for inbound TCP connections (pickle and plain). defaulting to 2min if unspecified (e.g. old config files)
  • make windows build again by forking whisper related dependencies and stripping out all the stuff we don't need (which was using linux specific syscalls)

@Dieterbe Dieterbe changed the title WIP: tcp timeouts TCP timeouts Oct 22, 2018
@Dieterbe Dieterbe changed the title TCP timeouts TCP input timeouts Oct 22, 2018
@Dieterbe
TCP read timeout for plain and pickle
6cb5d23 
fix #250
replace #251
@Dieterbe
add TCP closing log
72df9cc
@Dieterbe
messages when cliens open/close conn should be debug
5975a65 
because some clients open and close connections all the time.
in particular, our own graphite instrumentation library does it,
and when it sends into our own input we don't want to flood our log
@Dieterbe
default to 2 minutes, allow 0s to disable
664d696
@Dieterbe Dieterbe requested a review from DanCech October 23, 2018 10:50
@Dieterbe Dieterbe merged commit 2e6cd61 into master Oct 23, 2018
@Dieterbe Dieterbe mentioned this pull request Oct 29, 2018
Closed
This was referenced Mar 10, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanCech DanCech DanCech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dieterbe @DanCech