Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported file formats #38

Open
HelgeStenstrom opened this issue Sep 9, 2019 · 5 comments
Open

Supported file formats #38

HelgeStenstrom opened this issue Sep 9, 2019 · 5 comments
Assignees
Labels
enhancement help wanted improvement Refactorings and internal structure improvements

Comments

@HelgeStenstrom
Copy link
Collaborator

The description claims that java-stream-player supports ogg, flac, speex and other formats. How does that happen? I have searched for the word flac in the code, but haven't found it.

It would be good with a few small sample audio files in the supported formats. The files should be free to use, of course.

@goxr3plus goxr3plus self-assigned this Sep 10, 2019
@goxr3plus
Copy link
Owner

You can try to play .flac and it plays :) But i don't think it supports any .flac you will add :) . Yes we need small samples for all audio formats .

@goxr3plus goxr3plus added enhancement help wanted improvement Refactorings and internal structure improvements labels Sep 10, 2019
@HelgeStenstrom
Copy link
Collaborator Author

I haven't tested with flac, but I might have some file on my drive.
But the question was: How does it happen? In other words:
Where is the implementation of flac support? Which part of the software is aware of different audio file types?

@goxr3plus
Copy link
Owner

@HelgeStenstrom Tha's a nice question :) . Look how it works .

We have added

java-stream-player/pom.xml

Lines 107 to 111 in f1ba0e3

<dependency>
<groupId>org.jflac</groupId>
<artifactId>jflac-codec</artifactId>
<version>1.5.2</version>
</dependency>

which gives as the ability to play .flac files . But how that attaches to our library right ? Well it downloads the .jar file which if you open has inside has the below :

image

From which java audio system understands which codec to use for .flac files . Actually i was reading about this in some old Java Tutorials .

@HelgeStenstrom
Copy link
Collaborator Author

I saw that in the pom file, but I don't see where the jflac-codec is actually used. Maybe I didn't find it because the package name is different from the artifactId.

I'll have to test with a flac file someday.

@goxr3plus
Copy link
Owner

Maybe i add a special package called AudioTools which the user can use to retrieve audio data , duration , read .mp3 metadata etc . i have it in XR3Player but i should export it here .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted improvement Refactorings and internal structure improvements
Projects
None yet
Development

No branches or pull requests

2 participants