Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you test for open? #37

Open
HelgeStenstrom opened this issue Sep 8, 2019 · 1 comment
Open

Why do you test for open? #37

HelgeStenstrom opened this issue Sep 8, 2019 · 1 comment
Labels
improvement Refactorings and internal structure improvements question

Comments

@HelgeStenstrom
Copy link
Collaborator

On the line above the test, you just opened the sourceDataLine. Don't you trust that it worked?
If it didn't work, if the line wasn't opened, isn't that a reason to throw an exception, rather than silently ignore the failure?

@HelgeStenstrom HelgeStenstrom added question improvement Refactorings and internal structure improvements labels Sep 8, 2019
@goxr3plus
Copy link
Owner

Yep let's combine it with #36 and code a solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Refactorings and internal structure improvements question
Projects
None yet
Development

No branches or pull requests

2 participants