Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default priority configurable #312

Closed
bhopmann opened this issue May 4, 2020 · 6 comments
Closed

Make default priority configurable #312

bhopmann opened this issue May 4, 2020 · 6 comments
Labels
a:feature New feature or request

Comments

@bhopmann
Copy link

bhopmann commented May 4, 2020

Is your feature request related to a problem? Please describe.
No, it isn't.

Describe the solution you'd like
It would be helpful, if the default priority (currently set to 0) would be configurable via config file and environment variables.

Describe alternatives you've considered
I haven't considered alternatives.

Additional context
There's no additional context.

@bhopmann bhopmann added the a:feature New feature or request label May 4, 2020
@jmattheis
Copy link
Member

I try to keep the settings of Gotify to a minimum. I think it doesn't hurt to always set the priority when sending a message. Let's wait for more feedback to decide if this feature should be implemented.

@Leosirth
Copy link

I think this would be useful.

I have a scenario where I'm sending notification from Grafana to Gotify.
Grafana doesn't allow to change the payload or to add parameters so the default priority is used (0) and the message is delivered silently to the clients.

I think having the possibility to set a default priority would help on this situation.

In my opinion this will be even better if it could be configured at application level instead of globally.
So we can have a default priority set differently for each application (if provided, otherwise 0 would be used).

@mdino-gh
Copy link

mdino-gh commented Mar 9, 2021

Hi,
I try to use Gotify notification from my synology disk station. I managed it to configure it under SMS service provider. But if I am configuring the priority in the disk station configuration it is being sent as "priority":"5". Gotify denies the request because the priority value is quoted and therefore it seems that it's interpreted as a string instead of an integer.

{"error":"Bad Request","errorCode":400,"errorDescription":"json: cannot unmarshal string into Go struct field MessageExternal.priority of type int"}

I am not sure about JSON specification and I couldn't find a clear statement that quoting of integers is wrong.

Anyways if it would be possible e.g. to define a default priority for each application that would do a great job.

@hadogenes
Copy link

I think it would be best if you could configure default priority per app (in Applications page)

@rightsaidfred99
Copy link

I wish

@jmattheis
Copy link
Member

https://github.com/gotify/server/releases/tag/v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request
Development

No branches or pull requests

6 participants