Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): fix concurrent access problem of rand.Rand #694

Merged
merged 1 commit into from
May 31, 2023

Conversation

WisperDin
Copy link
Contributor

fix issue: #693

@zhenghaoz zhenghaoz linked an issue May 31, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (d2ebeb0) 69.78% compared to head (195ca32) 69.85%.

❗ Current head 195ca32 differs from pull request most recent head 434c1f4. Consider uploading reports for the commit 434c1f4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   69.78%   69.85%   +0.06%     
==========================================
  Files          63       63              
  Lines       11954    11965      +11     
==========================================
+ Hits         8342     8358      +16     
+ Misses       2833     2832       -1     
+ Partials      779      775       -4     
Impacted Files Coverage Δ
base/random.go 78.66% <0.00%> (-13.53%) ⬇️
worker/worker.go 67.13% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhenghaoz zhenghaoz merged commit 863e506 into gorse-io:master May 31, 2023
@zhenghaoz zhenghaoz added the backport release-0.4 Backport to release-0.4 label May 31, 2023
@zhenghaoz
Copy link
Collaborator

/backport

@github-actions
Copy link
Contributor

Successfully created backport PR for release-0.4:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-0.4 Backport to release-0.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concurrent access rand seed in worker package occur panic
2 participants