Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] uBlock disabled on first unloaded tab on the left #820

Closed
gwarser opened this issue Oct 13, 2015 · 4 comments
Closed

[Firefox] uBlock disabled on first unloaded tab on the left #820

gwarser opened this issue Oct 13, 2015 · 4 comments

Comments

@gwarser
Copy link
Contributor

gwarser commented Oct 13, 2015

Set Firefox to restore session from last time, and don't load tabs until selected.
Open few tabs. Select either tab on the right.
Restart browser.
Right click on tab bar on the first tab on the left, and select 'Reload Tab', wait until loaded. (may be automatically loaded when using Auto Unload Tab tabPreLoader extension)
Switch to this tab.
uBlock icon is grey, power button is grey, nothing is blocked.

It works when simply switching to first tab, but some resources may slip through.

Fx 41.0.1 on Linux Mint 17.2,
Fx 43a2 on Windows 7
uBlock 1.2.2b2

Example url:
https://encrypted.google.com/search?q=buy+iphone
https://www.inoreader.com/all_articles

Broken:
broken
Reloaded:
reloaded

@gorhill
Copy link
Owner

gorhill commented Oct 13, 2015

Ok, reproduced -- though uBlock is not disabled on my side but it did not detect properly which domain is 1st-party. When not reloading the tab first, uBlock detects properly the first-party domain of the page.

@gorhill
Copy link
Owner

gorhill commented Oct 13, 2015

Firefox's tab management is really complicated...

  1. The tab is created when Firefox launches
  2. It's URI is about:blank
  3. It's pending attribute is NOT set (unexpected)
  4. Eventually LocationChangeListener for the tab is called with https://www.inoreader.com/all_articles
  5. However its pending attribute is now set...
  6. Which means the event is ignored, and thus the tab is not rebound to the proper URI.

@gorhill
Copy link
Owner

gorhill commented Oct 13, 2015

Correction: the unexpected missing pending attribute happens only for the 1st tab, not the others... Ugh.

@gwarser
Copy link
Contributor Author

gwarser commented Oct 13, 2015

Looks good, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants