Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] popup block for all sites #630

Closed
seth100 opened this issue Aug 24, 2015 · 5 comments
Closed

[request] popup block for all sites #630

seth100 opened this issue Aug 24, 2015 · 5 comments
Labels

Comments

@seth100
Copy link

seth100 commented Aug 24, 2015

Hi,

is it possible to add the possibility to set an option to block popups for all sites?
Something like what this addon does: https://addons.mozilla.org/en-US/firefox/addon/pop-up-control/?src=cb-dl-updated

Thanks for your great work.

@harshanvn
Copy link

option to block popups for all sites?

It's already there. Try adding this rule no-popups: * true in My Rules tab.

And read more about popup blocking here https://github.com/gorhill/uBlock/wiki/Quick-guide:-popup-user-interface#no-popups

@seth100
Copy link
Author

seth100 commented Aug 24, 2015

Ok thanks.

@seth100 seth100 closed this as completed Aug 24, 2015
@seth100 seth100 reopened this Aug 26, 2015
@seth100
Copy link
Author

seth100 commented Aug 26, 2015

I have tried that, but I can see that it really blocks all popups including all sites that have links that open in a new tab.
The extension I have reported above https://addons.mozilla.org/en-US/firefox/addon/pop-up-control/?src=cb-dl-updated does make difference, indeed it does not prevent sites from opening links in a new tab, but block the popups that uBlock can't block with filters.

@gorhill
Copy link
Owner

gorhill commented Aug 26, 2015

See CONTRIBUTING. Provide all the details please.

@gorhill
Copy link
Owner

gorhill commented Sep 14, 2015

Closing due to no detailed repro steps provided.

@gorhill gorhill closed this as completed Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants