Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic issue #579

Closed
zummuz opened this issue Aug 7, 2015 · 4 comments
Closed

cosmetic issue #579

zummuz opened this issue Aug 7, 2015 · 4 comments

Comments

@zummuz
Copy link

zummuz commented Aug 7, 2015

Hi. There is cosmetic issue: ublock doesn't show requests for domain (colour signs and +/- signs) on some sites.
For example 2 sites:
https://www.reddit.com/
http://www.avclub.com/
ublock
I have noticed that sites with the issue have in common one script request from main domain (picture below). But I can't find with logger which script specifically.
umatrix
Chromium 46
Windows 7

@g3939434
Copy link

g3939434 commented Aug 8, 2015

But I can't find with logger which script specifically.

The script is inline-script, which doesn't count as requests blocked.

@zummuz
Copy link
Author

zummuz commented Aug 8, 2015

The script is inline-script, which doesn't count as requests blocked.

But the script request from 1st party domain was counted (allowed one) in umatrix. I thought there could be green sign and + sign in ublocks field (reddit.com).
Its not significant issue, if it is an issue at all. I'd like gorhill to see these posts to be sure its ok.

@gorhill
Copy link
Owner

gorhill commented Aug 8, 2015

uBlock and uMatrix work differently.

In uMatrix, the inline script tags, if present, are globally counted as one 1st-party script resource, because the user must be informed if there are script tags present, in order to be able to decide whether to block or allow 1st-party scripts.

In uBlock, the same inline script tags are not counted as a separate resource, as there is one cell dedicated for inline script tags specifically.

Edit: For uBlock, having a + or - sign in the Inline scripts cell to indicate whether there are allowed/blocked inline script tags would be useful I suppose.

@zummuz
Copy link
Author

zummuz commented Aug 8, 2015

Ok, its not an issue but a feature then. Thanks

@zummuz zummuz closed this as completed Aug 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants