Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from requests to httpx #484

Open
uriyyo opened this issue Mar 21, 2023 · 4 comments
Open

Switch from requests to httpx #484

uriyyo opened this issue Mar 21, 2023 · 4 comments
Assignees
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@uriyyo
Copy link

uriyyo commented Mar 21, 2023

httpx is a modern, fully type annotated HTTP python client that has both sync and async clients implemented.

I guess it will be great to switch to it, and it should be pretty easy cause it is fully compatible with requests public interface.

And as far as it has async support it should be easier to implement #368.

@uriyyo uriyyo added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 21, 2023
@wangela
Copy link
Member

wangela commented Mar 21, 2023

If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.

@uriyyo Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@icfly2
Copy link

icfly2 commented Jun 26, 2023

Getting the speed of this client up would be great, it is very slow at the moment, managing only 5 requests per second, well below the limits

@ThugPigeon653
Copy link

ThugPigeon653 commented Sep 19, 2023

I would like to implement this, if nobody else is already working on it?
*EDIT: @wangela given python doesn't have builtin async functionality, would this really be a worthwhile endeavour?

Thanks

@Ousret
Copy link

Ousret commented Dec 6, 2023

Hello there,

Sorry to barge in,
There's an alternative you may be interested in. https://github.com/jawah/niquests

This is a drop-in-worthy replacement for Requests that ships with modern capabilities and allows you a painless transition.
I can answer any concerns you may have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants