Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme is using deprecated method #195

Open
jt-gilkeson opened this issue May 10, 2023 · 2 comments
Open

Readme is using deprecated method #195

jt-gilkeson opened this issue May 10, 2023 · 2 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@jt-gilkeson
Copy link

The readme is showing the following:

    lifecycle.coroutineScope.launchWhenCreated {
        val googleMap = mapFragment?.awaitMap()
    }

as the example of how to use this, but that code has been deprecated.
Can you update the readme to have a more current example?

Is:

     lifecycleScope.lifecycleScope.launch {
         lifecycle.repeatOnLifecycle(Lifecycle.State.CREATED) {
             val googleMap = mapFragment?.awaitMap()
         }
     }

the correct way to use this now?

@jt-gilkeson jt-gilkeson added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 10, 2023
@wangela
Copy link
Member

wangela commented May 10, 2023

If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.

@jt-gilkeson Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@wangela wangela added priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Aug 7, 2023
@wangela
Copy link
Member

wangela commented Aug 7, 2023

Thanks for the suggestion! Feel free to contribute a pull request for the README featuring your improved code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

No branches or pull requests

2 participants