Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior change: Ticket cleanup mechanism #163

Open
yfei1 opened this issue Mar 7, 2020 · 1 comment
Open

Behavior change: Ticket cleanup mechanism #163

yfei1 opened this issue Mar 7, 2020 · 1 comment

Comments

@yfei1
Copy link
Collaborator

yfei1 commented Mar 7, 2020

Goal of this issue:
Opened this issue to track if there is any feedback against this behavior change.

Background:
Open Match has a ticket auto-expiring mechanism since v0.4.0. However, this expiration logic will introduce some memory leak in Redis so starting from v0.10.0, we will remove the ticket auto-expiring logic from our statestore implementation in googleforgames/open-match#1146. After this change, users are now responsible for deleting any unused/invalid tickets that have created in Open Match.

TODOs:
Document this behavior change in v0.10 release and the ticket cleanup mechanism in Open Match

@yfei1 yfei1 self-assigned this Mar 7, 2020
@thevilledev
Copy link

Good choice. Currently in v0.9.0 the Redis expiration time is a burdensome thing to configure, and it affects all tickets in the system. Removing this implicit expiration and providing the ticket creation times with googleforgames/open-match#1162 in the Ticket proto is a much more flexible approach.

@Laremere Laremere transferred this issue from googleforgames/open-match May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants