Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only first line of BREAKING CHANGE is shown #440

Closed
coreyfarrell opened this issue May 19, 2020 · 0 comments · Fixed by #627
Closed

Only first line of BREAKING CHANGE is shown #440

coreyfarrell opened this issue May 19, 2020 · 0 comments · Fixed by #627
Assignees
@bcoe
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@coreyfarrell
Copy link

Environment details

I'm running release-please from @bcoe's Github action https://github.com/bcoe/release-please-action v1.1.0 (running in ubuntu-latest).

Steps to reproduce

  1. Create a commit with a multi-line BREAKING CHANGE message.
feat: Implement something

BREAKING CHANGE: This commit breaks something which warrants
a description that spans multiple lines.
  1. Observe the generated change log, the BREAKING CHANGE only shows the first line.

Example

See cfware/babel-plugin-remove-ungap#20 and the associated commit message at cfware/babel-plugin-remove-ungap@a70cca3.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 20, 2020
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 21, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label May 21, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Aug 19, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Nov 15, 2020
@bcoe bcoe mentioned this issue Nov 16, 2020
Merged
@bcoe bcoe closed this as completed in #627 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcoe bcoe

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include multi-line breaking changes googleapis/release-please
3 participants
@bcoe @coreyfarrell @yoshi-automation