Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase upper limit for protobuf 5.X versions #212

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

RobPasMue
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #211 🦕

@RobPasMue RobPasMue requested a review from a team as a code owner March 26, 2024 08:24
Copy link

google-cla bot commented Mar 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 26, 2024
@RobPasMue
Copy link
Contributor Author

I have the CLA signed with my personal email... but I can't change it to my GitHub email which is 37798125+RobPasMue​@users.noreply.github.com... is there any way around this?

@parthea
Copy link
Contributor

parthea commented Mar 26, 2024

Thanks for opening a PR, @RobPasMue! Please see the CLA troubleshooting section here:
https://opensource.google/documentation/reference/cla#troubleshoot

I'm wondering if deprecation warnings for protobuf 3.x and 4.x should be emitted as compatibility of _pb2.py files may not be guaranteed across multiple major versions of protobuf. Alternatively, we could drop support for protobuf 3.x and 4.x (which would also help #135 (comment) as we would be able to upgrade grpcio-tools and use a newer version of protoc).

Please allow some time for me to discuss with my colleagues on the best approach. In the meantime, if presubmits pass, we could proceed with your proposed change. A separate PR could be prepared at a later time to deprecate/drop protobuf 3.x/4.x and eventually upgrade grpcio-tools. If presubmits fail, we may need to drop support for protobuf 3.x/4.x and upgrade grpcio-tools in order to add support for protobuf 5.x.

# NOTE: Pin the version of grpcio-tools to 1.48.2 for compatibility with
# Protobuf 3.19.5. Please ensure that the minimum required version of
# protobuf in setup.py is compatible with the pb2 files generated
# by grpcio-tools before changing the pinned version below.
GRPCIO_TOOLS_VERSION = "grpcio-tools==1.48.2"

@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 26, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 26, 2024
@RobPasMue
Copy link
Contributor Author

That'd be great @parthea - let me know if I can be of any help!

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2024
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2024
@parthea parthea self-assigned this Mar 28, 2024
@RobPasMue
Copy link
Contributor Author

Hi @parthea! Any news here?

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 26, 2024
@parthea parthea changed the title build: increase upper limit for protobuf 5.X versions fix: increase upper limit for protobuf 5.X versions Apr 26, 2024
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RobPasMue!

@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024
@parthea parthea enabled auto-merge (squash) April 26, 2024 11:05
@RobPasMue
Copy link
Contributor Author

Thanks @parthea! Any reason why the workflow is not running?

@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2024
@parthea parthea disabled auto-merge April 26, 2024 11:29
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2024
@parthea
Copy link
Contributor

parthea commented Apr 26, 2024

@RobPasMue, For the OwlBot Post Processor check there is no feedback while the workflow is running however the status will be reported once it's finished. I'll follow up on it to make sure it passes.

@RobPasMue
Copy link
Contributor Author

Awesome, thanks! Really appreciated

@parthea parthea merged commit 28fc17a into googleapis:main Apr 26, 2024
11 checks passed
@noam-better
Copy link

noam-better commented May 27, 2024

Hello, when will this make it onto PyPi? Currently still showing 1.63.0 with the incorrect <5.0 protobuf dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for protobuf 5.X
4 participants