-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show logs when TFX pipelines are submitted #976
Conversation
@@ -273,6 +274,10 @@ def submit( | |||
if network: | |||
self._gca_resource.network = network | |||
|
|||
# Prevents logs from being supressed on TFX pipelines | |||
if self._gca_resource.pipeline_spec["sdkVersion"].startswith("tfx"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the unit tests to include a mock tfx pipeline similar to this:
https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/aiplatform/test_pipeline_jobs.py#L76
It can then be added to parameterize the current tests here:
https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/aiplatform/test_pipeline_jobs.py#L240
You may need to update the expected call in the test to add sdkVersion
: https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/aiplatform/test_pipeline_jobs.py#L285
Fixes an issue where calling
PipelineJob.submit()
with TFX pipelines didn't show any logs. This was happening because whentfx.v1
is imported, the log level gets set toWARNING
. I added a check for TFX pipelines and reset the log level toINFO
.Fixes b/209602615.