Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table.getRows() has missing options in its types #330

Closed
lostpebble opened this issue Jan 17, 2019 · 0 comments
Closed

table.getRows() has missing options in its types #330

lostpebble opened this issue Jan 17, 2019 · 0 comments
Assignees
@lostpebble
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. TypeScript

Comments

@lostpebble
Copy link
Contributor

Environment details

  • @google-cloud/bigquery version: 2.0.6

Steps to reproduce

  1. Try use table.getRows(options)
  2. Can't pass in selectedFields or startIndex, as is possible with the direct HTTP endpoint.

I've confirmed that passing those fields into the function does work as expected (at least in my small use case).

I see that behind the scenes its calling the BigQuery HTTP API directly, so I assume these fields are possible, should work as expected and are just missing the the current types.
@lostpebble lostpebble mentioned this issue Jan 17, 2019
Merged
2 tasks
@JustinBeckwith JustinBeckwith added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. TypeScript labels Jan 17, 2019
@google-cloud-label-sync google-cloud-label-sync bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Jan 31, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostpebble lostpebble

Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustinBeckwith @lostpebble @yoshi-automation