Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Core): Fix Batch failure file's content with end of line character. #6528

Merged
merged 8 commits into from
Aug 5, 2023

Conversation

yash30201
Copy link
Contributor

@yash30201 yash30201 commented Aug 3, 2023

Fixes #5308

Full Context: b/234355684

@yash30201 yash30201 marked this pull request as ready for review August 3, 2023 09:31
@yash30201 yash30201 requested review from a team as code owners August 3, 2023 09:31
@yash30201 yash30201 added api: core priority: p2 Moderately-important priority. Fix may not be included in next release. semver: patch A minor bug fix or small change. labels Aug 3, 2023
@yash30201 yash30201 changed the title fix(Core/Batch): Fix failure file's content with end of line character. fix(Core): Fix Batch failure file's content with end of line character. Aug 3, 2023
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yash30201 yash30201 merged commit f696f2a into googleapis:main Aug 5, 2023
20 checks passed
@yash30201 yash30201 deleted the batch-b/234355684 branch August 7, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release. semver: patch A minor bug fix or small change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BatchRunner retry fails if the entry has newline characters in its serialization
3 participants