feat:[Spanner] CacheSessionPool::maintain deletes sessions older than 28d #5853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwarajanand
force-pushed
the
issue-5827
branch
from
71c65f4
to
481998c
Compare
bshaffer
requested changes
Feb 10, 2023
vishwarajanand
force-pushed
the
issue-5827
branch
from
aed0f23
to
4ec44f3
Compare
vishwarajanand
force-pushed
the
issue-5827
branch
from
0f29ec9
to
34cf8ad
Compare
|
@bshaffer I force-pushed to get rid of conventional commit error, due to first commit. |
bshaffer
reviewed
Feb 21, 2023
bshaffer
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes: #5827
Changes
maintain()to purge sessions older than 28d.CacheSessionPool::isSessionValid(..)['creation']param, which is set to time in seconds when session was created and only used to check for expiration.Tests
Both UT and System tests are passing in prod.