fix(logging): Fix deprecation message in PsrLogger with PHP 8.1 #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
In PHP 8.1, when implementing `Serializable` without implementing the magic `serialize`/`__unserialize` methods, a deprecation warning will be generated. This PR adds these methods and moves the logic as to not duplicate any code but still provide BC for >= PHP 7.2. Tests remain unchanged and working. The Serializable interface will be removed in PHP 9.0: - RFC: https://wiki.php.net/rfc/phase_out_serializable - Deprecation Warning docs: https://www.php.net/manual/en/class.serializable.php >As of PHP 8.1.0, a class which implements Serializable without also implementing __serialize() and __unserialize() will generate a deprecation warning.
bshaffer
approved these changes
Jan 11, 2022
bshaffer
reviewed
Jan 13, 2022
bshaffer
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Thanks for the suggestion fixes @bshaffer! Looking at both failed builds, they seem unrelated to the changes made here since commit fe54725 worked but b246a78 failed (they do the same thing). One failure is also due to CodeSniffer OOM Would be great to get this merged in the near future since it prevents tools like Infection PHP from working 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 8.1, when implementing
Serializablewithout implementing the magic__serialize/__unserializemethods, a deprecation warning will be generated.This PR adds these methods and moves the logic as to not duplicate any code but still provide BC for >= PHP 7.2. Tests remain unchanged and working.
The
Serializableinterface will be removed in PHP 9.0: