Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a configurable wait time between messages sent for server streaming RPCs #1306

Closed
blakeli0 opened this issue May 8, 2023 · 1 comment · Fixed by #1309
Closed

Add a configurable wait time between messages sent for server streaming RPCs #1306

blakeli0 opened this issue May 8, 2023 · 1 comment · Fixed by #1309
Assignees
@blakeli0
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@blakeli0
Copy link
Contributor

blakeli0 commented May 8, 2023

We want to add a showcase test for server stream wait timeout that is introduced in this PR, but found that this is not supported at this moment.

Potential solution:

  • Add a field serverStreamWaitTime to ExpandRequest
  • Add a sleep time here based on the value set above.
@blakeli0 blakeli0 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 8, 2023
@blakeli0 blakeli0 self-assigned this May 8, 2023
@blakeli0 blakeli0 changed the title Add a configurable delay between messages sent for server streaming RPCs Add a configurable wait time between messages sent for server streaming RPCs May 8, 2023
@blakeli0 blakeli0 mentioned this issue May 8, 2023
Merged
@noahdietz
Copy link
Collaborator

Cool, yeah makes sense. Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakeli0 blakeli0

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@blakeli0 @noahdietz