-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated code doesn't honor proto3 optional
semantics
#848
Comments
Just adding +1 here to mention this is impacting the Node.js client library for the Google Ads API: https://github.com/Opteo/google-ads-api . With the upcoming deprecation of Ads API V4/5 in June, developers using this library need enough time to migrate versions without encountering errors as a result of this bug. |
We are only waiting for protobuf.js release, then it will just go up through the dependency chain with no changes needed in google-gax or here. To try it, |
(and as for protobuf.js release, it's coming soon - I'm working on it; it's a third party library but we can release it) |
It should all work now (after reinstalling dependencies and regenerating protos with |
|
Absolutely awesome work, many thanks! I have a question: The issue is intended to be fixed on the version |
Google Ads API uses proto3
optional
throughout, and the distinction between a field having a default value vs. not being present at all in a message is meaningful. The current behavior of the generated Node.js protos appears to be setting default values for all fields, regardless of whether the message actually has the field set.The text was updated successfully, but these errors were encountered: