Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support alternative http bindings in the gapic schema. #993

Merged
merged 6 commits into from
Sep 15, 2021

Conversation

kbandes
Copy link
Contributor

@kbandes kbandes commented Sep 14, 2021

This completes part of yon-mg's PR, #776. The template changes will be in a separate PR.

@kbandes kbandes requested a review from a team as a code owner September 14, 2021 19:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2021
@kbandes kbandes changed the title Support alternative http bindings in the gapic schema. feat: Support alternative http bindings in the gapic schema. Sep 14, 2021
Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: are these additions intended to replace or complement the existing http_opt property? I think we should probably have only one. The names are too similar to be easily distinguished without reading the code.

gapic/schema/wrappers.py Outdated Show resolved Hide resolved
gapic/schema/wrappers.py Outdated Show resolved Hide resolved
gapic/schema/wrappers.py Outdated Show resolved Hide resolved
gapic/schema/wrappers.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants