Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo attribue -> attribute #627

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

busunkim96
Copy link
Contributor

Closes #626

It might be nice to add fake grpc service configs to make sure this bit of the template is tested.

@busunkim96 busunkim96 requested review from a team as code owners September 30, 2020 19:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Fatfinger on my part.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #627   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1537      1537           
  Branches       310       310           
=========================================
  Hits          1537      1537           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0644b52...eba2a40. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.34.0 fails to generate grafeas v1
3 participants