-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GOOGLE_API_USE_MTLS support #420
Conversation
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1451 1451
Branches 300 300
=========================================
Hits 1451 1451 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor comments.
Implement the logic in go/python-apiary-mtls, section 2.2 (replaced
client_encrypted_cert_source
withclient_cert_source
because microgenerator doesn't use encrypted client key)For the following logic, part 2 is implemented in Client constructor, part 1 is implemented in GrpcTransport constructor.